feat(api): distributed lock service should reuse in memory provider svc #3123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-fernandez
requested review from
davidsoderberg,
LetItRock,
ainouzgali,
scopsy,
BiswaViraj and
djabarovgeorge
|
LGTM |
p-fernandez
force-pushed
the
nv-1951-in-memory-provider-service
branch
2 times, most recently
from
a0af746
to
ee93597
Compare
p-fernandez
force-pushed
the
nv-1957-distributed-lock-should-reuse-in-memory
branch
from
754cbbd
to
3e50ad5
Compare
p-fernandez
force-pushed
the
nv-1951-in-memory-provider-service
branch
4 times, most recently
from
4a833b5
to
ce9ac1f
Compare
p-fernandez
force-pushed
the
nv-1957-distributed-lock-should-reuse-in-memory
branch
2 times, most recently
from
8b61263
to
54e30e4
Compare
p-fernandez
force-pushed
the
nv-1957-distributed-lock-should-reuse-in-memory
branch
from
54e30e4
to
73ed00f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Makes the distributed lock service to reuse the in-memory provider service.
Why was this change needed?
We plan to implement Redis cluster as in-memory provider service for the Cache service and the Distributed Lock service. So far we had both connections to the in-memory provider (ioredis) separatedly even if using the same instance.
Other information (Screenshots)