fix: add reply to support for aws ses provider #3131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-fernandez
reviewed
Apr 4, 2023
p-fernandez
suggested changes
Apr 5, 2023
| @@ -12,6 +12,7 @@ const mockConfig = { | |||
|
|
|||
| const mockNovuMessage = { | |||
| to: ['test@test2.com'], | |||
| replyTo: 'test@test1.com', | |||
There was a problem hiding this comment.
I think that this is not enough to test if replyTo is being configured in SES.
In line 96 we should modify the spy to check that the proper params and values are passed by checking with the method toHaveBeenCalledWith and the values passed in the mockNovuMessage.
Unfortunately it wasn't done properly before but if not doing it we can't validate this change. 🙁
btw. @p-fernandez Not sure if you have been notified, but I have updated the PR, can you please check? |
|
Looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Why was this change needed?
replyTowasn't working for AWS SES provider. This PR fixes that bug.Closes #3122