refactor: remove duplicate cache service initialization

[scopsy]

What change does this PR introduce?

Previously the caching service was initialized 3 times because it was injected another un-needed time.

Why was this change needed?

I'm concerned that we have a split connection for some of the redis calls.

Other information (Screenshots)

[scopsy]

@p-fernandez is there any specific reason for the previous implementation? Or is it okey if we change it to this?

[p-fernandez]

@p-fernandez is there any specific reason for the previous implementation? Or is it okey if we change it to this?

The current implementation was to follow our instantiation pattern and the way I quickly found the less times the services were initialised.
What I do not understand from the PR is that there is no Cache Service changes related even if that is the goal of the PR.

[LetItRock]

@scopsy @p-fernandez
I'm wondering why can't we just use the DI mechanism to inject the InMemoryProviderService to the CacheService and DistributedLockService?... we have here above the provider object and we do call useFactory two times which creates two instances of InMemoryProviderService...

[LetItRock]

@p-fernandez is there any specific reason for the previous implementation? Or is it okey if we change it to this?

The current implementation was to follow our instantiation pattern and the way I quickly found the less times the services were initialised. What I do not understand from the PR is that there is no Cache Service changes related even if that is the goal of the PR.

the CacheService is initialized in the shared module where we do pass the instance on InMemoryProviderService

[p-fernandez]

the CacheService is initialized in the shared module where we do pass the instance on InMemoryProviderService

I might miss any nuance but I do not think these changes would remove the double initialisation for the CacheService. Unless the goal of the task is to reduce the initialisations of the InMemoryProviderService to create less instances of the ioredis client downstream, that indeed is happening.

[LetItRock]

the CacheService is initialized in the shared module where we do pass the instance on InMemoryProviderService

I might miss any nuance but I do not think these changes would remove the double initialisation for the CacheService. Unless the goal of the task is to reduce the initialisations of the InMemoryProviderService to create less instances of the ioredis client downstream, that indeed is happening.

we will still create two instances of InMemoryProviderService, check this comment: #3199 (comment)

[scopsy]

Yes exactly what @p-fernandez, just previously there was a third instance of the cache service without a really need for it, since the 2 we have right now are the actually needed ones.