fix: missing email override #3207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scopsy
reviewed
Apr 16, 2023
apps/api/src/app/events/usecases/send-message/send-message-email.usecase.ts
Outdated
Show resolved
Hide resolved
scopsy
reviewed
Apr 16, 2023
apps/api/src/app/events/usecases/send-message/send-message-email.usecase.ts
Outdated
Show resolved
Hide resolved
scopsy
approved these changes
Apr 16, 2023
|
@djabarovgeorge could you merge this from next with Pawel's work? this file has been moved |
scopsy
approved these changes
Apr 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Update the override to be taken from override and not override[providerId].
Why was this change needed?
Not sure if it was an intended/bug or feature but we need the update in order for us to be provider agnostic on the email override object.
Other information (Screenshots)