fix: dont store deleted template that are missing in next env(prod) #3209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-temaplte-delete # Conflicts: # apps/api/src/app/notification-template/e2e/create-notification-templates.e2e.ts
p-fernandez
approved these changes
Apr 17, 2023
| @@ -22,7 +22,7 @@ import { isSameDay } from 'date-fns'; | |||
| import { CreateNotificationTemplateRequestDto } from '../dto'; | |||
|
|
|||
| import axios from 'axios'; | |||
| // import { SendMessageEmail } from '../../events/usecases/send-message/send-message-email.usecase'; | |||
| // import { SendMessageEmail } from '../../events/usecases/send-message'; | |||
|
@djabarovgeorge Can we merge this? |
Definitely just was wondering if we want to archive this template state as deleted prod. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
do not store templates that were in dev and then were deleted. (without being promoted to prod before)
Why was this change needed?
At the moment if the user will create a template work/edit it (without promoting to prod) then decides he does not need it in prod and delete it. once he will promote it for the first time a new template will be created (not deleted)
In the beginning, i created a solution where we store the templated but in the deleted state, but then I thought about we will probably not want to store templates that were not in prod env.
@scopsy LMKWYT maybe we do want to store then :)
Other information (Screenshots)