feat(cluster): add prefix to distributed lock for autopipelining #3217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-fernandez
requested review from
davidsoderberg,
LetItRock,
ainouzgali,
scopsy,
BiswaViraj,
djabarovgeorge and
Cliftonz
p-fernandez
commented
Apr 17, 2023
Comment on lines
+139
to
+147
| // Unlock is still called even when the lock expires by going over TTL but errors | ||
| expect(spyUnlock).toHaveBeenCalledTimes(1); |
There was a problem hiding this comment.
This change wasn't properly propagated in other PR. Adding again.
p-fernandez
commented
Apr 17, 2023
packages/application-generic/src/services/distributed-lock/distributed-lock.service.ts
Outdated
Show resolved
Hide resolved
p-fernandez
force-pushed
the
feat-add-ioredis-prefix-to-distr-lock
branch
from
bf1ce59
to
9d7b241
Compare
p-fernandez
commented
Apr 17, 2023
Comment on lines
+56
to
+59
| (elem) => | ||
| elem.defaultValue !== undefined && | ||
| elem.defaultValue !== null && | ||
| !this.isSystemVariable(elem.name) |
There was a problem hiding this comment.
Cspell complaining 🙄
scopsy
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Allows the
autopipeliningfeature of Ioredis in Cluster mode to be used by the DistributedLock service.Why was this change needed?
Seems we are still seeing spikes and probably head-of-line blocking is happening. We have
autopipeliningenabled in our Redis Cluster configuration. Adding the prefix should help to the problems we are noticing it.Other information (Screenshots)