Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): Add infobip provider documentation #3221

Merged
merged 2 commits into from
Apr 19, 2023

Conversation

peoray
Copy link
Contributor

@peoray peoray commented Apr 17, 2023

What change does this PR introduce?

Add Infobip provider documentation

Why was this change needed?

Other information (Screenshots)

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 17, 2023
Copy link
Contributor

@p-fernandez p-fernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟


## Getting Started

To use the Infobip channel, you will need to create a Infobip account and add your API key and Base URL to the Infobip integration on the Novu platform.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To use the Infobip channel, you will need to create a Infobip account and add your API key and Base URL to the Infobip integration on the Novu platform.
To use the Infobip provider in the email channel, you will need to create a Infobip account and add your API key and Base URL to the Infobip integration on the Novu platform.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the case for most of the documentation. Do I go ahead and change it in all the files?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, you can do it in a separate PR. I updated also my suggestion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do 👍🏽 . Updated

@p-fernandez p-fernandez added this pull request to the merge queue Apr 19, 2023
Merged via the queue into novuhq:next with commit 28a86ae Apr 19, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants