Inject CONTEXT_PATH variables defined in .env to images for reverse proxy routing #3226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inject the *CONTEXT_PATH environment variables to the images
p-fernandez
reviewed
Apr 18, 2023
There was a problem hiding this comment.
We might need also to add context path for the new Worker app we are splitting from the API app.
CC: @scopsy @Cliftonz @LetItRock I found this ok but might need to wait for the Worker app.
@p-fernandez the worker app is not exposed to the outside, it's like internal app without APIs |
LetItRock
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
The proposed modification aims to inject the *CONTEXT_PATH variables defined in the .env file into the images.
Why was this change needed?
The deployment docker-compose file was not including the environment variables required to set the CONTEXT_PATH feature, which created a problem for those who wanted to use routes with a reverse proxy such as Nginx instead of having separate subdomains for each app. The proposed modification addresses this issue by ensuring that the necessary environment variables are included in the deployment file.
https://discord.com/channels/895029566685462578/1097448355237462017