Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add new providers in readme #3229

Merged
merged 2 commits into from
Apr 19, 2023

Conversation

jainpawan21
Copy link
Member

What change does this PR introduce?

Why was this change needed?

Other information (Screenshots)

- [ ] Bandwidth
- [ ] RingCentral

#### 📱 Push

- [x] [FCM](https://github.com/novuhq/novu/tree/main/providers/fcm)
- [x] [Expo](https://github.com/novuhq/novu/tree/main/providers/expo)
- [x] [SNS](https://github.com/novuhq/novu/tree/main/providers/sns)
- [x] [APNS](https://github.com/novuhq/novu/tree/main/providers/apns)
- [ ] OneSignal
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No links to Onesignal and Pushwoosh?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These providers are not yet available

- [x] [Burst SMS](https://github.com/novuhq/novu/tree/main/providers/burst-sms)
- [x] [Firetext](https://github.com/novuhq/novu/tree/main/providers/firetext)
- [x] [Infobip](https://github.com/novuhq/novu/tree/main/providers/infobip)
- [x] [SNS](https://github.com/novuhq/novu/tree/main/providers/sns)
- [ ] Bandwidth
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. Any reason why we are not linking to it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These providers are not yet available

@p-fernandez p-fernandez added this pull request to the merge queue Apr 19, 2023
Merged via the queue into next with commit 5496ce0 Apr 19, 2023
7 checks passed
@p-fernandez p-fernandez deleted the fix/add-new-sms-email-providers-in-readme branch April 19, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants