feat: switch to using production node env instead of env #3236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
@novu/api
@novu/dal
@novu/web
@novu/webhook
@novu/worker
@novu/ws
labels
scopsy
added a commit
that referenced
this pull request
Apr 19, 2023
* feat: switch to using production node env instead of env * fix: prod missing var * feat: add await for jobs in cypress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Switched
prodtoproductionwhen specified in theNODE_ENVas the optimizations only happened whenproductionis set notprod.Why was this change needed?
Switching the NODE_ENV environment variable to “production” in Node.js is important for performance because it enables various optimizations within the Node.js runtime and third-party libraries designed to improve performance in production environments. For example, it may disable certain debugging features, enable caching of compiled templates, and enable more aggressive garbage collection. Some libraries may behave differently or provide additional optimizations when running in production mode.
Other information (Screenshots)