fix(api): improve the flow of mark message as use case for performance #3238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-fernandez
requested review from
davidsoderberg,
LetItRock,
ainouzgali,
scopsy,
BiswaViraj and
djabarovgeorge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Parallelises 2 calls mutually independent for quicker execution and avoids an unnecessary loop if user is not admin.
Why was this change needed?
Noticed this flow improvement when analysing calls pre yesterday's deployment where calls to
markAsendpoint were quite slow. The biggest improvement has come from our infrastructure changes but decided to add this small thing as an extra.Other information (Screenshots)