feat(app-generic): add cluster pipeline logging in cache service #3256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-fernandez
requested review from
davidsoderberg,
LetItRock,
ainouzgali,
scopsy,
BiswaViraj and
djabarovgeorge
scopsy
reviewed
Apr 20, 2023
| await pipeline.exec(); | ||
| } catch (error) { | ||
| Logger.error( |
There was a problem hiding this comment.
Let's rethrow this error, Otherwise we silence it and it can lead to strange errors
There was a problem hiding this comment.
It is already silenced upstream in the InvalidateCache, FYI. But I will throw it to that layer as it was before.
p-fernandez
force-pushed
the
feat-add-cluster-pipeline-logging
branch
from
2a35c58
to
cb5d727
Compare
scopsy
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Adds extra logging for the Cluster Pipeline execution inside of the Cache Service.
Why was this change needed?
We were receiving errors in Sentry that weren't captured in NewRelic.
Other information (Screenshots)