-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docs): Add plivo provider documentation #3293
Conversation
@peoray |
@jainpawan21 how do we intend to add images? |
@peoray images are stored today at the /static folder for images. And served by docasaurus. Located in this folder: https://github.com/novuhq/novu/tree/next/docs/static/img They can than be referenced with the /static path from the .md files |
Thank you @scopsy Pardon my many questions, since there's no similar example to follow, I'd like to be clear on what to do. I don't mind also working on current docs and adding the images where necessary once I understand what to do |
@peoray really up to you :) You can create a folder for the provider, I agree that it will be easier to maintain on the long run. |
@peoray Do you still have plans to update this? |
Yes @unicodeveloper |
Although, I can't show images for adding the |
No problem. Can you update it with the ones available? |
Sure, I'll update the PR today. Will ping you |
@unicodeveloper please take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
Just maybe even if not harmful next time split the PR in 2, one for each provider.
Thank you for your contribution.
🌟
What do you mean @p-fernandez |
To have splitted in 2 different PRs the Plivo and the Africa's Talking documentation additions. 🙂 |
@p-fernandez This is one PR, I just pulled the changes from AT cause it had the images folder setup since it was the first provider that I did with images and I didn't want to cause a conflict |
What change does this PR introduce?
Add documentation for Plivo SMS provider
Why was this change needed?
Other information (Screenshots)