-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement git submodules #3297
Conversation
NV-2177 Implement Git Submodules for the private repository
Why? (Context)We would like to have an ability to hide some parts of the code from the open-source. For ex. a code for the Timed Digest calculations stored in a private repository package. This package will be only available for the cloud and enterprise users. What?We are going to use Git Submodule pointing to the private repository: https://github.com/novuhq/packages-enterprise.git Definition of DoneThe private repository packages available as the Git submodule in the Novu main repository. Only the core dev team should have an access to it. |
package.json
Outdated
@@ -146,6 +146,7 @@ | |||
"apps/*", | |||
"libs/*", | |||
"packages/*", | |||
"packages-enterprise/*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"packages-enterprise/*", | |
"enterprise/*", |
@LetItRock what do you think for jsut calling this enterprise
as the folder?
Hey there @LetItRock |
@djabarovgeorge thanks for the suggestion, I've added it the way you suggested ;) |
What change does this PR introduce?
Implement Git Submodules for the private repository
Why was this change needed?
Other information (Screenshots)