Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement git submodules #3297

Merged
merged 3 commits into from
May 5, 2023
Merged

Conversation

LetItRock
Copy link
Contributor

@LetItRock LetItRock commented Apr 27, 2023

What change does this PR introduce?

Implement Git Submodules for the private repository

Why was this change needed?

Other information (Screenshots)

Screenshot 2023-04-27 at 18 13 53

@LetItRock LetItRock self-assigned this Apr 27, 2023
@linear
Copy link

linear bot commented Apr 27, 2023

NV-2177 Implement Git Submodules for the private repository

Why? (Context)

We would like to have an ability to hide some parts of the code from the open-source. For ex. a code for the Timed Digest calculations stored in a private repository package. This package will be only available for the cloud and enterprise users.

What?

We are going to use Git Submodule pointing to the private repository: https://github.com/novuhq/packages-enterprise.git

Definition of Done

The private repository packages available as the Git submodule in the Novu main repository. Only the core dev team should have an access to it.

@LetItRock LetItRock marked this pull request as ready for review April 28, 2023 14:27
@LetItRock LetItRock changed the base branch from next to timed-digest April 28, 2023 14:27
package.json Outdated
@@ -146,6 +146,7 @@
"apps/*",
"libs/*",
"packages/*",
"packages-enterprise/*",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"packages-enterprise/*",
"enterprise/*",

@LetItRock what do you think for jsut calling this enterprise as the folder?

@djabarovgeorge
Copy link
Contributor

Hey there @LetItRock
I left a small question on the notion doc that is related to this PR
https://www.notion.so/Git-Submodules-243ac16a181c4bb49d51241c63bc9226?d=b8af0cbde51243dfbc1c8f4294ed1c5d#f1d48465df2a4ba1ac92bb7accf173b0

@LetItRock
Copy link
Contributor Author

Hey there @LetItRock I left a small question on the notion doc that is related to this PR https://www.notion.so/Git-Submodules-243ac16a181c4bb49d51241c63bc9226?d=b8af0cbde51243dfbc1c8f4294ed1c5d#f1d48465df2a4ba1ac92bb7accf173b0

@djabarovgeorge thanks for the suggestion, I've added it the way you suggested ;)

@LetItRock LetItRock requested a review from scopsy May 4, 2023 10:51
@LetItRock LetItRock changed the title [WIP] feat: implement git submodules feat: implement git submodules May 4, 2023
@LetItRock LetItRock merged commit 67428a3 into timed-digest May 5, 2023
29 checks passed
@LetItRock LetItRock deleted the nv-2177-git-submodule branch May 5, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants