fix: add sender name option in mailjet #3303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ainouzgali
approved these changes
Apr 30, 2023
There was a problem hiding this comment.
@jainpawan21 looks good :)
I saw that there are other providers not supporting senderName, maybe we should open tickets about them? Maybe community members could help us with those
| @@ -41,7 +41,7 @@ | |||
| "start:docker:embed": "cd libs/embed && npm run start:docker", | |||
| "start:docker:widget": "cross-env nx run-many --target=start:docker --projects=@novu/widget", | |||
| "docker:build": "pnpm -r --if-present --parallel docker:build", | |||
| "build": "nx run-many --target=build --exclude=angular-notification-center-example,vue-notification-center-example --all", | |||
There was a problem hiding this comment.
Was this removed on purpose? What is behind this?
Yeah we should open tickets for them. @sumitsaurabh927 this might be your chance to dig in to the code. WDYT? |
|
Sure @unicodeveloper |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Add senderName option in mailjet provider
Why was this change needed?
With mailjet as active integration, sender name was not visible in email
Other information (Screenshots)