Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nv 2197 create UI for design for timed digest #3331

Merged
merged 13 commits into from
May 8, 2023

Conversation

davidsoderberg
Copy link
Contributor

@davidsoderberg davidsoderberg commented May 4, 2023

Screenshot 2023-05-04 at 11 30 15

Screenshot 2023-05-04 at 11 30 22

Screenshot 2023-05-04 at 11 30 28

Screenshot 2023-05-04 at 11 30 35

Screenshot 2023-05-04 at 11 30 42

Screenshot 2023-05-04 at 11 30 48

Copy link
Contributor

@LetItRock LetItRock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey 👋 I've found a few things to fix:

  1. The min tab value is not selected, and I feel like we should provide here a default every value, and we should have a FE validation logic for min/max (it partially works now).
    Screenshot 2023-05-05 at 00 26 26
  2. Hourly, similar default every value and the min/max validation logic.
  3. Daily, similar default every value and the min/max validation logic. When every is ex. 13, then the label should be like: Every 13th day. If the time value is not selected the at part should not be shown.
    Screenshot 2023-05-05 at 00 27 26
  4. Weekly, similar default every value and the min/max validation logic. And I feel like we should select by default the current weekday, because daily without selected days means - every week at the current day.
    Screenshot 2023-05-05 at 00 28 27
  5. Monthly, similar default every value and the min/max validation logic. Similarly, I think we should select the current month's day.
    Screenshot 2023-05-05 at 00 30 12
  6. When the "On the" monthly option is selected the label is not updated.
    Screenshot 2023-05-05 at 00 30 36

Copy link
Contributor

@LetItRock LetItRock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The timed metadata should be updated with appropriate values when submitting it to the BE, now we do send both weekdays and month days
Screen.Recording.2023-05-05.at.00.57.29.mov
  1. We should probably hide the FE digest scheduling under the enterprise flag, because for the OS it doesnt have any sense to show it without any BE logic.

@LetItRock LetItRock merged commit b61a6b5 into timed-digest May 8, 2023
28 of 30 checks passed
@LetItRock LetItRock deleted the nv-2197-create-ui-for-design-for-timed-digest branch May 8, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants