-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nv 2197 create UI for design for timed digest #3331
Merged
LetItRock
merged 13 commits into
timed-digest
from
nv-2197-create-ui-for-design-for-timed-digest
May 8, 2023
Merged
Nv 2197 create UI for design for timed digest #3331
LetItRock
merged 13 commits into
timed-digest
from
nv-2197-create-ui-for-design-for-timed-digest
May 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
davidsoderberg
commented
May 4, 2023
•
edited
edited
LetItRock
reviewed
May 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey 👋 I've found a few things to fix:
- The min tab value is not selected, and I feel like we should provide here a default every value, and we should have a FE validation logic for min/max (it partially works now).
- Hourly, similar default every value and the min/max validation logic.
- Daily, similar default every value and the min/max validation logic. When every is ex. 13, then the label should be like:
Every 13th day
. If the time value is not selected theat
part should not be shown.
- Weekly, similar default every value and the min/max validation logic. And I feel like we should select by default the current weekday, because daily without selected days means - every week at the current day.
- Monthly, similar default every value and the min/max validation logic. Similarly, I think we should select the current month's day.
- When the "On the" monthly option is selected the label is not updated.
LetItRock
reviewed
May 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The
timed
metadata should be updated with appropriate values when submitting it to the BE, now we do send both weekdays and month days
Screen.Recording.2023-05-05.at.00.57.29.mov
- We should probably hide the FE digest scheduling under the enterprise flag, because for the OS it doesnt have any sense to show it without any BE logic.
LetItRock
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.