Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove query to message templates #3351

Merged
merged 2 commits into from
May 7, 2023

Conversation

ainouzgali
Copy link
Contributor

What change does this PR introduce?

We query message templates just to get the step types. I don't see why it is needed.

Why was this change needed?

Other information (Screenshots)

@linear
Copy link

linear bot commented May 7, 2023

Copy link
Contributor

@djabarovgeorge djabarovgeorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@djabarovgeorge djabarovgeorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the tests are failing could you take a look there?

@djabarovgeorge djabarovgeorge self-requested a review May 7, 2023 14:04
@ainouzgali
Copy link
Contributor Author

ainouzgali commented May 7, 2023

I am on it :) @djabarovgeorge

Now I do see why its needed🤦🏻‍♀️ I will need more work on this

@ainouzgali ainouzgali marked this pull request as draft May 7, 2023 14:36
@ainouzgali ainouzgali marked this pull request as ready for review May 7, 2023 15:27
@ainouzgali ainouzgali added this pull request to the merge queue May 7, 2023
Merged via the queue into next with commit ad9a1ce May 7, 2023
25 checks passed
@ainouzgali ainouzgali deleted the nv-2233-remove-unneeded-query-for-message branch May 7, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants