Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nv 2243/add the sharable url in the integration #3356

Merged
merged 11 commits into from
May 14, 2023

Conversation

djabarovgeorge
Copy link
Contributor

What change does this PR introduce?

The Sharable URL is the URL that our users will need to share in their product in order to invite subscribers to provide access to send messages to their channel.

Why was this change needed?

In order to help the users with the Sharable URL generation.

Other information (Screenshots)

@linear
Copy link

linear bot commented May 8, 2023

NV-2243 Add the Sharable URL in the integration

Why? (Context)

In order to help the users with the Sharable URL generation.

What?

The Sharable URL is the URL that our users will need to share in their product in order to invite subscribers to provide access to send messages to their channel.

Definition of Done

Copy link
Contributor

@p-fernandez p-fernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes and suggestions!

@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 14, 2023
…the-integration' into NV-2243/add-the-sharable-url-in-the-integration
…ble-url-in-the-integration

# Conflicts:
#	apps/web/src/pages/integrations/components/ConnectIntegrationForm.cy.tsx
Copy link
Contributor

@ainouzgali ainouzgali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Just about passing watch - another option will be to pass control and use useWatch, but it doesn't really matter here.

@djabarovgeorge
Copy link
Contributor Author

Looks good to me. Just about passing watch - another option will be to pass control and use useWatch, but it doesn't really matter here.

Think we are good there because, in the following PR, I removed the use of the watch :)

@djabarovgeorge djabarovgeorge added this pull request to the merge queue May 14, 2023
Merged via the queue into next with commit 0469633 May 14, 2023
35 checks passed
@djabarovgeorge djabarovgeorge deleted the NV-2243/add-the-sharable-url-in-the-integration branch May 14, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation @novu/api @novu/shared @novu/web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants