-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nv 2243/add the sharable url in the integration #3356
Nv 2243/add the sharable url in the integration #3356
Conversation
NV-2243 Add the Sharable URL in the integration
Why? (Context)In order to help the users with the Sharable URL generation. What?The Sharable URL is the URL that our users will need to share in their product in order to invite subscribers to provide access to send messages to their channel. Definition of Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small changes and suggestions!
apps/web/src/pages/integrations/components/ConnectIntegrationForm.tsx
Outdated
Show resolved
Hide resolved
apps/web/src/pages/integrations/components/Modal/ConnectIntegrationForm.tsx
Outdated
Show resolved
Hide resolved
apps/web/src/pages/integrations/components/Modal/ConnectIntegrationForm.tsx
Outdated
Show resolved
Hide resolved
apps/web/src/pages/integrations/components/Modal/ConnectIntegrationForm.tsx
Show resolved
Hide resolved
apps/web/src/pages/integrations/components/Modal/ConnectIntegrationForm.tsx
Show resolved
Hide resolved
…oarding feat: update slack docs
…the-integration' into NV-2243/add-the-sharable-url-in-the-integration
…ble-url-in-the-integration # Conflicts: # apps/web/src/pages/integrations/components/ConnectIntegrationForm.cy.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Just about passing watch - another option will be to pass control and use useWatch, but it doesn't really matter here.
Think we are good there because, in the following PR, I removed the use of the watch :) |
What change does this PR introduce?
The Sharable URL is the URL that our users will need to share in their product in order to invite subscribers to provide access to send messages to their channel.
Why was this change needed?
In order to help the users with the Sharable URL generation.
Other information (Screenshots)