Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sent header #3361

Merged

Conversation

davidsoderberg
Copy link
Contributor

No description provided.

@linear
Copy link

linear bot commented May 9, 2023

NV-2240 Fix the timed digest "Will be sent" labels

Reproduction Steps

  1. The labels for the "Will be sent" are not correct when you select "Every" value ex. 13 and then select also the "at" time field. For ex. it shows the "Daily at 10:46", but should be "Every 13th day at 10:46".
  2. When you select the "Only frequent events" toggle and then switch to "Schedule" tab, it shows the "only if frequent events occur".

225456a3-a921-4782-8a80-794888b7f5df

Expected Behaviour

  1. The "at" time field selection should only have impact on the "at {time}" suffix of the label.
  2. The "only if frequent events occur" suffix should not be visible when selecting the "Schedule" tab.

if (type !== DigestTypeEnum.TIMED) {
return;
}
setValue(`steps.${index}.metadata.backoff`, false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe these fields should be set when creating a new node? but not sure if it will help

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will not because this is when switching type and not on create...

@davidsoderberg davidsoderberg merged commit 81ecb1d into timed-digest May 9, 2023
19 checks passed
@davidsoderberg davidsoderberg deleted the nv-2240-fix-the-timed-digest-will-be-sent-labels branch May 9, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants