-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add novu sharable url usecase #3371
Merged
djabarovgeorge
merged 9 commits into
next
from
NV-2258/create-novu-sharable-url-endpoint
May 14, 2023
Merged
feat: add novu sharable url usecase #3371
djabarovgeorge
merged 9 commits into
next
from
NV-2258/create-novu-sharable-url-endpoint
May 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NV-2258 ♻️ Create Novu Sharable URL endpoint
Why? (Context)For the user to use only one URL in order to set credentials for the chat channels under the same URL. What?New endpoint for requests from the user with an API key. this endpoint can reuse the same use case from the current logic use case. Definition of Done |
Base automatically changed from
NV-2256/docs-update-new-chat-onboarding
to
NV-2243/add-the-sharable-url-in-the-integration
May 14, 2023 07:39
…V-2258/create-novu-sharable-url-endpoint # Conflicts: # apps/web/src/pages/integrations/components/ConnectIntegrationForm.tsx # apps/web/src/pages/integrations/components/Modal/ConnectIntegrationForm.tsx
…/add-optional-hmac-slack-oauth-flow
ainouzgali
reviewed
May 14, 2023
Base automatically changed from
NV-2243/add-the-sharable-url-in-the-integration
to
next
May 14, 2023 09:16
ainouzgali
approved these changes
May 14, 2023
…oauth-flow Add optional HMAC slack OAuth flow
github-actions
bot
added
@novu/dal
documentation
Improvements or additions to documentation
labels
May 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
New endpoint for requests from the user with an API key. this endpoint can reuse the same use case from the current logic use case.
Why was this change needed?
For the user to use only one URL in order to set credentials for the chat channels under the same URL.
Other information (Screenshots)