fix: adjust pipelines by using submodules #3382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scopsy
approved these changes
May 10, 2023
.github/workflows/dev-deploy-api.yml
Outdated
| @@ -25,6 +25,7 @@ jobs: | |||
| uses: ./.github/workflows/reusable-api-e2e.yml | |||
| with: | |||
| ee: ${{ contains (matrix.name,'ee') }} | |||
| submodules: true | |||
There was a problem hiding this comment.
Shouldn't we add this here:
Suggested change
| submodules: true | |
| submodules: ${{ contains (matrix.name,'ee') }} |
?
| @@ -14,6 +14,7 @@ jobs: | |||
| uses: ./.github/workflows/reusable-api-e2e.yml | |||
| with: | |||
| ee: ${{ contains (matrix.name,'ee') }} | |||
| submodules: true | |||
There was a problem hiding this comment.
Suggested change
| submodules: true | |
| submodules: ${{ contains (matrix.name,'ee') }} |
Cliftonz
reviewed
May 10, 2023
| @@ -14,6 +14,7 @@ jobs: | |||
| uses: ./.github/workflows/reusable-worker-e2e.yml | |||
| with: | |||
| ee: ${{ contains (matrix.name,'ee') }} | |||
| submodules: true | |||
LetItRock
force-pushed
the
nv-2288-submodules-adjust-pipelines
branch
2 times, most recently
from
dbff1a9
to
efaa9d2
Compare
LetItRock
force-pushed
the
nv-2288-submodules-adjust-pipelines
branch
from
efaa9d2
to
c93dac3
Compare
LetItRock
force-pushed
the
nv-2288-submodules-adjust-pipelines
branch
7 times, most recently
from
0a94bdd
to
84a9010
Compare
LetItRock
force-pushed
the
nv-2288-submodules-adjust-pipelines
branch
from
84a9010
to
c62efe0
Compare
davidsoderberg
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Adjust the GitHub pipelines to also use the submodules. In this PR:
Why was this change needed?
Other information (Screenshots)