feat: add light themed icons for digest #3388
Conversation
davidsoderberg
commented
May 11, 2023
davidsoderberg
commented
There was a problem hiding this comment.
@davidsoderberg Could we maybe move all the icons to design-system/icons? even if we create a digest folder in icons I think it will be nicer - so we can easily reuse and to have all icons in the same place
apps/web/src/pages/templates/workflow/digest/BackOffTooltipIcon.tsx
Outdated
Show resolved
Hide resolved
|
Its not possible to reuse the dark one with changing the stroke/fill etc? |
Not sure these will be reused as other because they are very specific for this location that is why I did not put them i design-system. I agree that we could have an icons folder in digest thu 😄 |
|
|
||
| if (colorScheme === 'light') { | ||
| return ( | ||
| <svg xmlns="http://www.w3.org/2000/svg" width="280" height="57" viewBox="0 0 280 57" fill="none"> |
There was a problem hiding this comment.
please run all the svg's through this tool: https://jakearchibald.github.io/svgomg/, to make them smaller in size
There was a problem hiding this comment.
Will it not ruin the quality?
There was a problem hiding this comment.
nope, because it's svg's vector graphics :) it just removes unnecessary staff and improved the paths
