-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add api param for delete message #3410
Conversation
NV-1628 🐛 Bug Report: Invalid openapi spec
📜 DescriptionThank you for adding an API spec in #571 . Unfortunately when trying to generate a client against it we discovered the spec has some validation errors. They seem like minor problems but I'd figure it was good to raise it. 👟 Reproduction steps
👍 Expected behaviorIt should not produce any validation errors. 👎 Actual Behavior with Screenshots0.11.0 errors
0.10.1 errors
📃 Provide any additional context for the Bug.Found in ghcr.io/novuhq/novu/api:0.10.1, exact same issues also present in 0.11.0 👀 Have you spent some time to check if this bug has been raised before?
🏢 Have you read the Contributing Guidelines?
Are you willing to submit PR?None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
What change does this PR introduce?
Add @ApiParam() Decorator in the delete message operation
Fix few array-related issues with OAS swagger
Mark payload as optional
Why was this change needed?
closes #2671
Other information (Screenshots)