Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update preference docs #3412

Merged
merged 7 commits into from
May 21, 2023
Merged

fix: update preference docs #3412

merged 7 commits into from
May 21, 2023

Conversation

jainpawan21
Copy link
Member

@jainpawan21 jainpawan21 commented May 14, 2023

What change does this PR introduce?

Update subscriber preference docs
Add template-level preference screenshot
Add few faqs

Why was this change needed?

Other information (Screenshots)

@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 14, 2023
@jainpawan21 jainpawan21 changed the title fix: add get and update subscriber preference code fix: update preference docs May 14, 2023
@jainpawan21 jainpawan21 self-assigned this May 14, 2023
@jainpawan21 jainpawan21 changed the base branch from next to main May 21, 2023 13:49
@jainpawan21 jainpawan21 marked this pull request as ready for review May 21, 2023 14:06
Novu allows two levels of preferences:-

- Template level channel preferences
- Subscriber level channel subscription preferences
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subscriber level channel subscription preferences

What does the subscription here refer to though?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind. i know what it means. Just felt weird initially

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can do Template-level and Subscriber-level

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

subscribing to particular channel

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@jainpawan21 jainpawan21 merged commit cf1aa45 into main May 21, 2023
25 checks passed
@jainpawan21 jainpawan21 deleted the fix/update-preference-docs branch May 21, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants