-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add migration to create in app integration #3424
feat: add migration to create in app integration #3424
Conversation
apps/api/migrations/in-app-integration/in-app-integration.migration.ts
Outdated
Show resolved
Hide resolved
providerId: InAppProviderIdEnum.Novu, | ||
channel: ChannelTypeEnum.IN_APP, | ||
credentials: encryptCredentials({ | ||
hmac: environment.widget.notificationCenterEncryption, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The hmac field is not encrypted right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No
providerId: InAppProviderIdEnum.Novu, | ||
channel: ChannelTypeEnum.IN_APP, | ||
credentials: encryptCredentials({ | ||
hmac: environment.widget.notificationCenterEncryption, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove the environment.widget.notificationCenterEncryption under the environment? if yes would it be part of this cycle?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should, not sure we should do it this cycle. My suggestion is to do it in a later release...
ae83213
into
nv-2232-to-in-app-notification-center-provider
What change does this PR introduce?
Add migration to create in app integration for existing orgs.