Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add migration to create in app integration #3424

Conversation

davidsoderberg
Copy link
Contributor

What change does this PR introduce?

Add migration to create in app integration for existing orgs.

@linear
Copy link

linear bot commented May 16, 2023

providerId: InAppProviderIdEnum.Novu,
channel: ChannelTypeEnum.IN_APP,
credentials: encryptCredentials({
hmac: environment.widget.notificationCenterEncryption,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hmac field is not encrypted right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No

providerId: InAppProviderIdEnum.Novu,
channel: ChannelTypeEnum.IN_APP,
credentials: encryptCredentials({
hmac: environment.widget.notificationCenterEncryption,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove the environment.widget.notificationCenterEncryption under the environment? if yes would it be part of this cycle?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should, not sure we should do it this cycle. My suggestion is to do it in a later release...

@davidsoderberg davidsoderberg merged commit ae83213 into nv-2232-to-in-app-notification-center-provider May 16, 2023
33 checks passed
@davidsoderberg davidsoderberg deleted the nv-2330-create-migrations-for-already-existing branch May 16, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants