Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove hmac setting in settings #3436

Conversation

davidsoderberg
Copy link
Contributor

What change does this PR introduce?

Remove hmac setting from settings page

Other information (Screenshots)

Screenshot 2023-05-17 at 07 57 33

@linear
Copy link

linear bot commented May 17, 2023

NV-2301 ⚙️ [Settings] Deprecate In App Center tab in the settings

Why? (Context)

Currently, we display In-App connection options in multiple places in the Novu product:

  1. Get started page, options presented: Demo App, React, Angular, JS, Vue

  2. Settings page, options presented: iFrame

    We want our users to have a clear understanding of where and how to connect a notification channel. We have an Integration store where we display all providers for all channels to connect. So we decided that In-App connection options should be also included in the Integration store in order to provide a single source of truth where users are able to connect to any channel he wants. The get started page will duplicate all connection options that will be presented in the Integration store. This is out of the scope of this task, it is just for the information.

What?

In-App Center tab on the Settings page

We don't need to present the only iFrame option in the settings tab because it will bring confusion that In-App can be connected only via iFrame. It is also not related to the settings because it's a guide on how to connect In-App and not a setting that a user can change or deactivate.

Solution

Hide the In-App Center tab on the Settings page

Definition of Done

The In-App Center tab on the Settings page is deprecated

@davidsoderberg davidsoderberg requested review from ainouzgali, LetItRock and scopsy and removed request for ainouzgali May 17, 2023 05:58
@davidsoderberg davidsoderberg merged commit 4dde058 into nv-2232-to-in-app-notification-center-provider May 17, 2023
23 checks passed
@davidsoderberg davidsoderberg deleted the nv-2301-settings-deprecate-in-app-center-tab-in branch May 17, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants