Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: emails null condition #3461

Merged
merged 1 commit into from
May 19, 2023
Merged

fix: emails null condition #3461

merged 1 commit into from
May 19, 2023

Conversation

jainpawan21
Copy link
Member

What change does this PR introduce?

Remove null type from emails

Why was this change needed?

Other information (Screenshots)

@linear
Copy link

linear bot commented May 19, 2023

NV-2355 🐛 Bug Report: activity feed search field returns incorrect result

📜 Description

Activity Feed search feature not working as expected

👟 Reproduction steps

  1. Ensure the "Activity Feed" has a lot of entries logged with various subscriberIds
  2. Do a search by subscriberId
  3. Observe the returned entries

👍 Expected behavior

It should filter out the entries by subscriberIds

👎 Actual Behavior with Screenshots

It actually returns all records from the Activity Feed

📃 Provide any additional context for the Bug.

No response

👀 Have you spent some time to check if this bug has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to submit PR?

None

Copy link
Contributor

@p-fernandez p-fernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟

@jainpawan21 jainpawan21 added this pull request to the merge queue May 19, 2023
Merged via the queue into next with commit 3344b5e May 19, 2023
35 checks passed
@jainpawan21 jainpawan21 deleted the NV-2355 branch May 19, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants