feat(api): implement mappers for the different contexts in feature flags #3465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-fernandez
requested review from
davidsoderberg,
LetItRock,
ainouzgali,
scopsy,
BiswaViraj and
djabarovgeorge
NV-2324 Mappers around Launch Darkly API
Launch Darkly has their own schema to manage the feature flags implemented by them. We need to be able to transform our own Novu information (user, environment, version) to the schema used by Launch Darkly and on reverse. Definition of done
|
p-fernandez
commented
May 19, 2023
| @@ -49,7 +49,8 @@ export class FeatureFlagsService { | |||
| } | |||
| } | |||
|
|
|||
| public async get<T>(key: FeatureFlagKey, context: IFeatureFlagContext, defaultValue: T): Promise<T> { | |||
| return await this.service.get(key, context, defaultValue); | |||
| public async get<T>(key: FeatureFlagKey, defaultValue: T, context: IFeatureFlagContext): Promise<T> { | |||
There was a problem hiding this comment.
swapped the order because I found it was a clearer API as the key and the default value are related and context might be optional in a further decision.
p-fernandez
force-pushed
the
nv-2324-mappers-around-launch-darkly-api
branch
from
8b3ae62
to
5c510db
Compare
Base automatically changed from
nv-2353-retrieve-feature-flag-from-launch-darkly
to
nv-2323-implement-launch-darkly-node-sdk
May 22, 2023 14:19
p-fernandez
force-pushed
the
nv-2323-implement-launch-darkly-node-sdk
branch
from
752a446
to
5c48630
Compare
p-fernandez
force-pushed
the
nv-2324-mappers-around-launch-darkly-api
branch
from
5c510db
to
d638ca4
Compare
davidsoderberg
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Adds mapping for the different potential contexts we might have for the feature flags (organization, environment, user).
Why was this change needed?
We need to adapt Novu's context to Launch Darkly's one.
Other information (Screenshots)
I am missing for now adding other contexts such as version and region that were discussed but we still don't have the implementation for them in the apps. The implementation of the contexts in this PR should be enough to give an idea how to implement them in the future.