NV-2335 - Template Store - Template store refactor web on blueprint creation to use #3467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NV-2335 [Template store] Refactor WEB on blueprint creation to use notification-template POST
At the moment we are using the /notification-template/:templateId/blueprint POST, we need to update this flow to create the template using the regular /notification-template POST request that is used by the client. The additional step that we will need to refactor is instead of sending the id of the blueprint we should pass the template snapshot. |
LetItRock
approved these changes
May 22, 2023
| } | ||
| }); | ||
|
|
||
| export async function createTemplateFromBlueprint({ |
There was a problem hiding this comment.
maybe this one should be moved to some util?
apps/api/src/app/notification-template/dto/create-notification-template.request.dto.ts
Outdated
Show resolved
Hide resolved
| @@ -14,7 +14,7 @@ export class CreateNotificationTemplateRequestDto implements ICreateNotification | |||
| @ApiProperty() | |||
| @IsString() | |||
| @IsDefined({ | |||
| message: 'Notification group must be provided', | |||
| message: 'Notification group must be provided ', | |||
There was a problem hiding this comment.
I found that if we won't have it that the next argument will miss a space, so I added it here but if it is persistent in all cases maybe looking at how to fix it globally will be a better idea.
Base automatically changed from
NV-2338/template-store-invalidate-the-cache-on-blueprints-update
to
next
May 22, 2023 09:53
djabarovgeorge
deleted the
NV-2335/template-store-refactor-web-on-blueprint-creation-to-use
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
At the moment we are using the /notification-template/:templateId/blueprint POST, we need to update this flow to create the template using the regular /notification-template POST request that is used by the client.
The additional step that we will need to refactor is instead of sending the id of the blueprint we should pass the template snapshot.
Why was this change needed?
Other information (Screenshots)