Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add in app card with modal in integration store #3472

Merged
merged 4 commits into from
May 23, 2023
Merged

feat: add in app card with modal in integration store #3472

merged 4 commits into from
May 23, 2023

Conversation

davidsoderberg
Copy link
Contributor

@linear
Copy link

linear bot commented May 22, 2023

NV-2364 Add modal and settings for in app in integration store

@davidsoderberg davidsoderberg marked this pull request as ready for review May 23, 2023 03:45
ainouzgali
ainouzgali approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@ainouzgali ainouzgali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

libs/shared/src/consts/providers/channels/in-app.ts Show resolved Hide resolved
apps/web/src/pages/integrations/IntegrationsStoreModal.tsx Show resolved Hide resolved
apps/web/src/pages/integrations/components/NovuInAppProviderModal.tsx Show resolved Hide resolved
apps/web/src/pages/integrations/components/NovuInAppProviderModal.tsx Show resolved Hide resolved
apps/web/src/pages/integrations/components/NovuInAppProviderModal.tsx Show resolved Hide resolved
@davidsoderberg davidsoderberg merged commit 8661d45 into nv-2232-to-in-app-notification-center-provider May 23, 2023
32 checks passed
@davidsoderberg davidsoderberg deleted the nv-2364-add-modal-and-settings-for-in-app-in branch May 23, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ainouzgali ainouzgali ainouzgali approved these changes

@p-fernandez p-fernandez Awaiting requested review from p-fernandez

@BiswaViraj BiswaViraj Awaiting requested review from BiswaViraj

@djabarovgeorge djabarovgeorge Awaiting requested review from djabarovgeorge

Assignees
No one assigned
Labels
@novu/shared @novu/web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidsoderberg @ainouzgali