feat(web): templates store - fe caching for blueprints #3484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NV-2359 🏪 [Template store] Implement the FE caching
What?We would like to cache the blueprints response in the localStorage or indexedDB for a one week as the items will change really rare. Why? (Context)To provide a better UX and fast feedback. Definition of DoneThe blueprints response is cached on FE for 1 week. |
djabarovgeorge
approved these changes
May 24, 2023
There was a problem hiding this comment.
If it works as expected then it looks good to me 🚀
small note not related to this pr, if I will have spare time I was thinking to get the same hardcoded popular templates (from @shared) to the client, if we will add this logic I think we can definitely reduce the client cache to 1 day, I really afraid we will abuse this client caching really fast 😅
Base automatically changed from
nv-2361-template-store-integrate-with-api
to
next
May 24, 2023 10:41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Added the FE caching logic for the blueprints, they will be cached for 1 week in the
indexedDB.Why was this change needed?
Templates Store PRD.
Other information (Screenshots)