feat: load balance between environments #3500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LetItRock
reviewed
May 26, 2023
|
|
||
| export const BLUEPRINTS_API_URL = | ||
| window._env_.REACT_APP_BLUEPRINTS_API_URL || isCypress | ||
| ? window._env_.REACT_APP_BLUEPRINTS_API_URL || process.env.REACT_APP_BLUEPRINTS_API_URL || 'http://localhost:1336' |
There was a problem hiding this comment.
window._env_.REACT_APP_BLUEPRINTS_API_URL allows to override that URL, should we keep that?
There was a problem hiding this comment.
we definitely can remove it, I left it is just in case we would want to override it.
| }; | ||
|
|
||
| export const POPULAR_TEMPLATES_GROUPED = | ||
| process.env.NODE_ENV === 'production' ? production().templates : development().templates; |
There was a problem hiding this comment.
why do we want to differentiate?
There was a problem hiding this comment.
because the ids will be different in different environments.
…-blueprint-api # Conflicts: # apps/api/src/app/blueprint/usecases/get-grouped-blueprints/consts.ts
ainouzgali
approved these changes
May 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
make sure that all environments that are not prod will point to dev api.
Why was this change needed?
remove the load of the requests from prod api.
Other information (Screenshots)
the things that are still missing: