-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update naming of markAllNotifications methods in react NC #3521
Conversation
NV-2390 correct naming of markAllNotifications methods in NC
What?
Why? (Context)user may think that Rather Definition of DoneCorrect naming of these methods as:-
so that users don't get confused in first reading |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome 🏆
Should we also add a change to headless ? To avoid confusion ? @jainpawan21 |
Do you mean this method in headless? @BiswaViraj wdyt, how this function is behaving? is it marking all or fetched? |
@jainpawan21, The methods in the headless package are correct, I changed them while I worked on it. |
@ainouzgali @BiswaViraj shall I merge this PR? |
What change does this PR introduce?
Changed:-
markAllNotificationsAsRead => markFetchedNotificationsAsRead
markAllNotificationsAsSeen => markFetchedNotificationsAsSeen
markAllNotificationsAsReadByFeed => markAllNotificationsAsRead
Added:-
markAllNotificationsAsSeen
Update Docs
Why was this change needed?
Other information (Screenshots)