Template Store - add create template from popular tests #3528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ainouzgali
approved these changes
May 29, 2023
| {hasTemplates ? ( | ||
| <Table | ||
| onRowClick={onRowClick} | ||
| loading={isLoading || areNotificationGroupLoading} |
There was a problem hiding this comment.
Suggested change
| loading={isLoading || areNotificationGroupLoading} | |
| loading={areNotificationGroupLoading} |
ainouzgali
reviewed
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Add loader to template list & no templates
Why was this change needed?
So the user will see the loader while the data is fetching, and after it is fetched we can show the data/skeletons
Other information (Screenshots)
Before
https://www.loom.com/share/133cd8324756431597d1f1e2f6e0cd88
After
https://www.loom.com/share/0022387b3b7247af9f3eb21764bb383f