Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): show add step side menu after delete of step #3593

Conversation

ainouzgali
Copy link
Contributor

What change does this PR introduce?

Fixes the following:

Select the step stat opens the step side settings like: digest, delay, sms, push, chat.
Try to delete the step, then the step side settings disappear and the default channels panel is not shown.

Fixed by navigating back to the basePath.

Why was this change needed?

Other information (Screenshots)

@linear
Copy link

linear bot commented Jun 14, 2023

NV-2224 The step side settings disappear after the step is deleted

Reproduction Steps

Select the step stat opens the step side settings like: digest, delay, sms, push, chat.

Try to delete the step, then you will notice that the step side settings disappear and the default channels panel is not shown.

e3dbf32f-385f-4c52-a152-b3ab62a6c03d

Expected Behaviour

After the step is deleted we should show the default channels panel.

Screenshot 2023-05-05 at 17.33.44.png

…p-side-settings-disappear-after-the-step-is-deleted
@p-fernandez p-fernandez self-assigned this Jun 14, 2023
Copy link
Contributor

@p-fernandez p-fernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟

@ainouzgali ainouzgali added this pull request to the merge queue Jun 14, 2023
Merged via the queue into next with commit 9db5575 Jun 14, 2023
25 of 26 checks passed
@ainouzgali ainouzgali deleted the https_/linear.app/novu/issue/NV-2224/the-step-side-settings-disappear-after-the-step-is-deleted branch June 14, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants