fix(ci): debugging cypress #3669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-fernandez
force-pushed
the
fix-ci-debug-cypress
branch
from
01d8c6d
to
6f285e9
Compare
p-fernandez
force-pushed
the
fix-ci-debug-cypress
branch
from
6f285e9
to
8126ea9
Compare
github-actions
bot
added
@novu/api
@novu/dal
@novu/webhook
@novu/worker
@novu/ws
labels
p-fernandez
force-pushed
the
fix-ci-debug-cypress
branch
from
dd25255
to
a5755f4
Compare
p-fernandez
commented
Jun 27, 2023
| @@ -48,7 +48,6 @@ | |||
| "@sentry/hub": "^7.40.0", | |||
| "@sentry/node": "^7.40.0", | |||
| "@sentry/tracing": "^7.40.0", | |||
| "@types/handlebars": "^4.1.0", | |||
There was a problem hiding this comment.
PNPM install script said were not needed.
p-fernandez
commented
Jun 27, 2023
| @@ -49,21 +49,19 @@ | |||
| "rimraf": "^3.0.2", | |||
| "superagent-defaults": "^0.1.14", | |||
| "supertest": "^5.0.0", | |||
| "twilio": "^3.62.0", | |||
There was a problem hiding this comment.
Unused (and has no sense).
scopsy
approved these changes
Jun 27, 2023
p-fernandez
force-pushed
the
fix-ci-debug-cypress
branch
from
65be112
to
e1a1fa7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Why was this change needed?
Other information (Screenshots)