feat: add initial tenants ui #3855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NV-2611 Initial Tenants Page UI
|
djabarovgeorge
commented
Jul 25, 2023
djabarovgeorge
commented
Jul 25, 2023
There was a problem hiding this comment.
basically the same as in the integration list page was not sure if creating a reusable component for both or not. due to the reason that this component is small and used in 2 places, I decided to duplicate the code for now. lmkwyt.
djabarovgeorge
commented
Jul 25, 2023
| @@ -201,7 +201,7 @@ function App() { | |||
| <Route path=":channel/:stepUuid" element={<TemplateEditor />} /> | |||
| </Route> | |||
| <Route path={ROUTES.WORKFLOWS} element={<WorkflowListPage />} /> | |||
| <Route path={ROUTES.TENANTS} element={<Tenants />} /> | |||
| <Route path={ROUTES.TENANTS} element={<TenantsPage />} /> | |||
There was a problem hiding this comment.
added the page part to make sure it is straightforward.
djabarovgeorge
commented
Jul 25, 2023
| const navigate = useNavigate(); | ||
|
|
||
| const onAddTenantClickCallback = useCallback(() => { | ||
| // navigate(); |
There was a problem hiding this comment.
we will navigate hit to the side bar that Gali is working on.
djabarovgeorge
commented
Jul 25, 2023
| return isLoading ? ( | ||
| <Skeleton width={100} height={20} /> | ||
| ) : ( | ||
| format(new Date(original.createdAt), 'dd/MM/yyyy HH:mm') |
There was a problem hiding this comment.
requested in the ticked by the design
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
The new Tenants page will show the list of tenants.
The API endpoint to get the tenants list was created in the previous cycle.
Why was this change needed?
We need a page to manage tenants
Other information (Screenshots)
https://www.loom.com/share/6bb92713c4714538a1e853dcba0f93af