fix: allow return 'data' as response prop #3876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scopsy
reviewed
Jul 30, 2023
| @@ -17,7 +17,7 @@ export class ResponseInterceptor<T> implements NestInterceptor<T, Response<T>> { | |||
| return next.handle().pipe( | |||
| map((data) => { | |||
| // For paginated results that already contain the data wrapper, return the whole object | |||
| if (data?.data) { | |||
| if (data?.data && !data?._id) { | |||
There was a problem hiding this comment.
Amazing! Maybe worth adding a small comment here on why it's added like this here.
scopsy
approved these changes
Jul 30, 2023
scopsy
approved these changes
Jul 30, 2023
djabarovgeorge
merged commit 4a7999e
into
nv-2452-tenant-create-a-tenant-sidebar
4 checks passed
djabarovgeorge
deleted the
fix-response-interceptor-to-return-data-as-a-prop
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
allow return 'data' as response prop
Why was this change needed?
so we could create entities with a 'data' prop on the root layer and return them properly.
Other information (Screenshots)