Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add migration script to add novu providers to database #3886

Conversation

davidsoderberg
Copy link
Contributor

What change does this PR introduce?

Add migration script for Novu providers.

Copy link
Contributor

@djabarovgeorge djabarovgeorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me left a small question regarding the open question for me. :)

Comment on lines +34 to +38
const countChannelIntegrations = await integrationRepository.count({
_environmentId: environment._id,
_organizationId: environment._organizationId,
channel,
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would we want to skip the creation if the user already has integration on the same channel?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No we just like to keep it disabled so the user that are used to see them still see them as usual even with the new list design

@davidsoderberg davidsoderberg merged commit f4a758b into nv-2503-store-novu-providers-email-sms-in-the-database Aug 2, 2023
16 checks passed
@davidsoderberg davidsoderberg deleted the nv-2559-create-migration-script-to-create-dev-and-prod-providers-for branch August 2, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants