Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nv 2588 multi provider multiple in app instances can be created #3910

Conversation

davidsoderberg
Copy link
Contributor

What change does this PR introduce?

Fix so not more then one in app provider can be created per environment

Other information (Screenshots)

Screenshot 2023-08-03 at 08 40 55

@linear
Copy link

linear bot commented Aug 3, 2023

NV-2588 Multi Provider - multiple in-app instances can be created

What?

  1. We should disable the creation of the in app provider if there is one already exists on the environment
  2. Once the user selects the environment which is already existing, just show an error message that says that only a single provider can be existing

Why? (Context)

Because right now we do not support more then one in-app per environment

Definition of Done

@davidsoderberg davidsoderberg marked this pull request as ready for review August 3, 2023 11:04
cy.getByTestId('providers-group-chat').contains('Chat').as('chatGroup');
cy.getByTestId('providers-group-push').contains('Push').as('pushGroup');
cy.getByTestId('providers-group-sms').contains('SMS').as('smsGroup');
cy.task('deleteProvider', {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to delete in app provider here because we create both on init session so for that option to be visibile we need to delete them here.

Copy link
Contributor

@LetItRock LetItRock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work 🎉

@davidsoderberg davidsoderberg added this pull request to the merge queue Aug 3, 2023
Merged via the queue into next with commit f814577 Aug 3, 2023
23 checks passed
@davidsoderberg davidsoderberg deleted the nv-2588-multi-provider-multiple-in-app-instances-can-be-created branch August 3, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants