Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fix cursors for drag buttons and drop area #3922

Merged
merged 1 commit into from
Aug 4, 2023
Merged

feat: fix cursors for drag buttons and drop area #3922

merged 1 commit into from
Aug 4, 2023

Conversation

davidsoderberg
Copy link
Contributor

@davidsoderberg davidsoderberg commented Aug 4, 2023 •
edited
Loading

What change does this PR introduce?

Change cursor for drag buttons and drop area

https://www.loom.com/share/bc4ec018019345088a55d4d5b3824647

@linear
Copy link

linear bot commented Aug 4, 2023

NV-2441 ❤️‍🩹 🏗️ [WE] Update cursor state while hovering elements in the WE

What?

  1. Workflow editor / Cursor displays wrong state (drag hand) while hovering hidden DnD area

    Expected: Cursor won't change the appearance

  2. The workflow editor / Cursor displays wrong state (pointer hand) while hovering channel cards on the right side

Why?

Cursor should display the correct state, to prevent decreasing the credibility of the UI.

How?

  1. Workflow editor / Cursor not to change the appearance while hovering hidden DnD area
  2. Workflow editor / Cursor display DRAG HAND while hovering channel cards on the right panel

https://www.loom.com/share/94daa073917d48d9adea62855eb52112

LetItRock
LetItRock approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@LetItRock LetItRock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@davidsoderberg davidsoderberg added this pull request to the merge queue Aug 4, 2023
Merged via the queue into next with commit 70d049c Aug 4, 2023
24 checks passed
@davidsoderberg davidsoderberg deleted the nv-2441-we-update-cursor-state-while-hovering-elements-in-the-we branch August 4, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LetItRock LetItRock LetItRock approved these changes

Assignees
No one assigned
Labels
@novu/web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidsoderberg @LetItRock