feat(ci): reuse instructions to tidy up pipelines #3975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-fernandez
force-pushed
the
feat-ci-tidy-up-pipelines-reusable-instructions
branch
from
d1ef839
to
42ab62a
Compare
p-fernandez
force-pushed
the
feat-ci-tidy-up-pipelines-reusable-instructions
branch
from
42ab62a
to
69dc5ae
Compare
p-fernandez
commented
Aug 15, 2023
| @@ -60,3 +60,7 @@ runs: | |||
| - name: 🛟 Install dependencies | |||
| shell: bash | |||
| run: pnpm install --frozen-lockfile | |||
|
|
|||
| - name: Install wait-on plugin | |||
There was a problem hiding this comment.
setup-project action is being used by all the workflows. Makes sense to install the dependency here and forget. Even if wait-on is not used in all the workflows the installation of it should be quick and is available as part of the tooling for the workflows.
p-fernandez
deleted the
feat-ci-tidy-up-pipelines-reusable-instructions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Tidy up the CI pipelines.
Why was this change needed?
Other information (Screenshots)