fix: Bug fixed for add filter button in production #4284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LetItRock updated the PR with the latest changes. Please verify it . Thanks |
added 2 commits
October 2, 2023 22:13
…com/sjcode99/novu into fix/show-filter-modal-in-production
|
@LetItRock, Ohh!!😮 I have missed this. Changes update, Please have a look. |
scopsy
requested changes
Oct 3, 2023
| @@ -9,6 +9,7 @@ import { DeleteStepButton, FilterButton } from './FilterModal.styles'; | |||
| import { OnlineFiltersForms } from './OnlineFiltersForms'; | |||
| import { PreviousStepFiltersForm } from './PreviousStepFiltersForm'; | |||
| import { useMemo } from 'react'; | |||
| import { boolean } from 'zod'; | |||
There was a problem hiding this comment.
This seems like it was imported by a mistake.
| @@ -44,7 +44,7 @@ export function StepSettings({ index }: { index: number }) { | |||
| onClick={() => { | |||
| setFilterOpen(true); | |||
| }} | |||
| disabled={readonly} | |||
| disabled={false} | |||
There was a problem hiding this comment.
Suggested change
| disabled={false} |
|
Hey @scopsy, removed the unnecessary import. Please have a look |
scopsy
approved these changes
Oct 3, 2023
|
Hey @LetItRock @scopsy . Seems my code is not yet merged. can you please help with this merge |
|
Hey @LetItRock, it's been a long since I created PR and I can still see it's not merged. Is there any issue in the code which needs to be addressed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
This PR fixes the bug for the Add Filter button in production
The change was to enable the add filter button in the production environment.
Fixes #4254