Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@novu/fcm): use message instead of body for data-type notifications #4652

Merged
merged 4 commits into from
Oct 26, 2023

Conversation

cherfia
Copy link
Contributor

@cherfia cherfia commented Oct 25, 2023

What change does this PR introduce?

Fixed the bug reported #4639 by including the message property in the data sent by the FCM provider, aligning with Expo documentation.

Why was this change needed?

The notifications were displaying only the titles and not rendering the notification message body.

Other information

While the body property is not required for data-type notifications, it has been retained for backward compatibility to support users who already rely on it.

@p-fernandez
Copy link
Contributor

Thanks for your contribution.
You will need to update the tests based on the change you have done.

@cherfia
Copy link
Contributor Author

cherfia commented Oct 26, 2023

@p-fernandez I have updated fcm.provider.spec.ts to include message property and NX Successfully ran target test for project @novu/fcm

Copy link
Contributor

@p-fernandez p-fernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.
🌟

@p-fernandez p-fernandez merged commit d6cd3b6 into novuhq:next Oct 26, 2023
24 of 27 checks passed
@cherfia
Copy link
Contributor Author

cherfia commented Oct 26, 2023

Thanks! I'm committed to ongoing contributions to Novu as it's integral part of our open-source solution ⭐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants