feat(application-generic, shared): Add Rate Limiting feature flag #4667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NV-3057 🏎️ Rate Limiting Feature Flag
What?Create a feature flag for the new API Rate Limiting feature called Why? (Context)All new features must have a feature flag. This feature flag will be long-lived to act as a kill-switch for rate-limiting in disaster scenarios. The environment variable provides the capability for self-hosted customers to opt in/out of rate limiting to optionally protect their service. Definition of Done
|
…/novuhq/novu into nv-3057-rate-limiting-feature-flag
rifont
commented
Oct 26, 2023
rifont
commented
Oct 26, 2023
packages/application-generic/src/usecases/get-feature-flag/get-use-merged-digest-id.use-case.ts
Show resolved
Hide resolved
LetItRock
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
IS_REQUEST_RATE_LIMITING_ENABLEDshared type enumfeature-flagsshared type to strictly type the flag naming conventions, and adds relevant type checking testsGetIsRequestRateLimitingEnableduse caseWhy was this change needed?
A feature flag is required for the new API Request Rate Limiting feature to safely introduce and release changes.
Other information (Screenshots)
n/a