Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make date path and authenticate by token optional #5045

Merged
merged 1 commit into from
Jan 29, 2024
Merged

fix: make date path and authenticate by token optional #5045

merged 1 commit into from
Jan 29, 2024

Conversation

jainpawan21
Copy link
Member

@jainpawan21 jainpawan21 commented Jan 3, 2024 •
edited
Loading

What change does this PR introduce?

  1. Updae datePath and authenticateByToken as required false in generic SMS provider
  2. Add current date as fall back date in response of generic SMS provider

Why was this change needed?

Other information (Screenshots)

@linear Linear
Copy link

linear bot commented Jan 3, 2024

NV-3329 make Authenticate by token toggle in generic provider as optional

@github-actions github-actions bot added the stale Pull Request that needs to be reviewed label Jan 28, 2024
@scopsy scopsy merged commit 70fc710 into next Jan 29, 2024
28 checks passed
@scopsy scopsy deleted the NV-3329 branch January 29, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scopsy scopsy scopsy approved these changes

Assignees
No one assigned
Labels
@novu/shared providers stale Pull Request that needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jainpawan21 @scopsy