fix(ci): CSpell action version update #5145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for dev-web-novu failed.
|
Cliftonz
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
In some cases, the CSpell github action fails to pickup spelling errors before merging to next branch. This results in next having failed builds for subsequent PRs.
Reference PR which had incorrect spelling but failed to be detected in CI prior to merge:
https://github.com/novuhq/novu/actions/runs/7114670957/job/19369189668?pr=4922#step:3:13
The same spelling error is presented in a new PR CI check:
https://github.com/novuhq/novu/actions/runs/7182546230/job/19559313593#step:3:27
We decided in the beginning to try to update the version because it's not easy to reproduce the BUG. Then if we see the same issue we reopen this ticket and kick off a deep investigation of it.
Why was this change needed?
It will be useful to update the action and try to fix the error, which happens very rarely
Other information (Screenshots)