Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: side bar title color based on theme #5155

Merged
merged 1 commit into from
Feb 5, 2024
Merged

fix: side bar title color based on theme #5155

merged 1 commit into from
Feb 5, 2024

Conversation

jainpawan21
Copy link
Member

What change does this PR introduce?

  1. Added black color in design-system colors
  2. fix sidebar title color based on theme

Why was this change needed?

Other information (Screenshots)

@linear Linear
Copy link

linear bot commented Feb 4, 2024

NV-3462 Workflow | Trigger - Title color doesn't change for light mode

@netlify Netlify
Copy link

netlify bot commented Feb 4, 2024 •
edited
Loading

❌ Deploy Preview for dev-web-novu failed.

Name Link
🔨 Latest commit d054f83
🔍 Latest deploy log https://app.netlify.com/sites/dev-web-novu/deploys/65bf41909622920008509fc0

@jainpawan21 jainpawan21 merged commit a7520e0 into next Feb 5, 2024
19 of 26 checks passed
@jainpawan21 jainpawan21 deleted the NV-3462 branch February 5, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scopsy scopsy scopsy approved these changes

Assignees
No one assigned
Labels
@novu/design-system @novu/web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jainpawan21 @scopsy