Nv 2997 reusable chat preview component #5157
Conversation
BiswaViraj
force-pushed
the
nv-2995-reusable-email-preview-component
branch
from
1c6b192
to
c3cb3b0
Compare
BiswaViraj
force-pushed
the
nv-2997-reusable-chat-preview-component
branch
from
6ee5841
to
5ce224b
Compare
| import { previewChat } from '../../../../api/content-templates'; | ||
| import { errorMessage } from '../../../../utils/notifications'; | ||
|
|
||
| export function ChatPreview() { |
There was a problem hiding this comment.
lets do a small refactoring in this file after Biswa in his PR applies the suggestions #5143
There was a problem hiding this comment.
I am merging this PR to my branch. I will handle this change with my refactor @LetItRock
There are many overlapping changes in both PRs, Merging now will help in avoiding conflicts
| import { useNavigate, useParams } from 'react-router-dom'; | ||
| import { useBasePath } from '../hooks/useBasePath'; | ||
|
|
||
| export function PreviewEditOverlay() { |
There was a problem hiding this comment.
seems like duplicated code apps/web/src/components/workflow/Preview/common/PreviewEditOverlay.tsx
| import { forwardRef } from 'react'; | ||
| import { IS_DOCKER_HOSTED } from '../../../config'; | ||
|
|
||
| export function LocaleSelect({ locales, value, isLoading, readonly, setSelectedLocale }) { |
There was a problem hiding this comment.
duplicated component? apps/web/src/components/workflow/Preview/common/LocaleSelect.tsx
There was a problem hiding this comment.
I think these were left behind after my rebase, coz i moved these components to the newly created common folder.
Will delete these
BiswaViraj
merged commit 5f93f0f
into
nv-2995-reusable-email-preview-component
What change does this PR introduce?
Preview chat component
Why was this change needed?
Other information (Screenshots)