Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): bulk create subscribers after they were deleted #5160

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

LetItRock
Copy link
Contributor

What change does this PR introduce?

When deleted subscribers are "recreated" with bulk create endpoint we will "mark" them as deleted: false (not deleted).

Why was this change needed?

Other information (Screenshots)

Screen.Recording.2024-02-06.at.10.17.40.mov

@LetItRock LetItRock self-assigned this Feb 6, 2024
Copy link

linear bot commented Feb 6, 2024

Copy link

netlify bot commented Feb 6, 2024

Deploy Preview for dev-web-novu failed.

Name Link
🔨 Latest commit 58ee177
🔍 Latest deploy log https://app.netlify.com/sites/dev-web-novu/deploys/65c1fb09b89e4b00096af656

Copy link
Contributor

@djabarovgeorge djabarovgeorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@LetItRock LetItRock merged commit 506ded1 into next Feb 6, 2024
28 of 32 checks passed
@LetItRock LetItRock deleted the nv-3471-fix-recreate-subscribers branch February 6, 2024 17:44
LetItRock added a commit that referenced this pull request Feb 7, 2024
fix(api): bulk create subscribers after they were deleted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants